Skip to content

Add show option for startFlow#1886

Merged
FrederikBolding merged 5 commits into
mainfrom
fb/silent-start-flow
Oct 24, 2023
Merged

Add show option for startFlow#1886
FrederikBolding merged 5 commits into
mainfrom
fb/silent-start-flow

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Oct 23, 2023

Explanation

Adds an show option for ApprovalController.startFlow(). Setting this to false lets you start a flow "silently", not triggering the popup. Instead the popup may be triggered by the next approval created or by a previously created approval.

Changelog

@metamask/approval-controller

  • Changed: Add show option for startFlow

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 23, 2023 16:54
Comment thread packages/approval-controller/src/ApprovalController.ts Outdated
@FrederikBolding FrederikBolding changed the title Add showOnFirstRequest option for startFlow Add show option for startFlow Oct 24, 2023
@FrederikBolding FrederikBolding merged commit 9574ae8 into main Oct 24, 2023
@FrederikBolding FrederikBolding deleted the fb/silent-start-flow branch October 24, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants